| Full description: | Filer changes since 53.35 (23.07.2023)
Work from 2026-11-14 on top of the 53.35 source. Commits: 4aed377 is the
original source, bcb09c4 the main work, followed by individual fixes.
Building
- Filer, FilerCX, Thumber and FilerPrefs build with the current OS4 SDK and
GCC 15 cross-compiler (
build_os4.sh).
- Globals are defined once in a
Globals.c per program, so -fcommon is not
needed.
- Include name case fixed (
FileType.h, Picasso96API.h).
- Deprecated calls replaced:
GetProgramName → GetCliProgramName,
DeleteFile → Delete, CreateMsgPort/DeleteMsgPort →
AllocSysObject/FreeSysObject, old EXDF_* names.
- FilerPrefs: ReAction object casts that GCC 14 and later require.
Packaging
- The release archive has an Install script (AmigaOS Installation Utility,
package/Install). It installs the Filer drawer (SYS:Utilities by
default), FilerCX in SYS:Utilities/Commodities with COMMAND and HOME set
to the installed Filer, and on request adds FilerCX to the WBStartup
preferences. The Installer can't write binary files, so the prefs entry
comes ready-made in Install.wbstartup (and Install.wbsheader when
there is no wbstartup.prefs yet) and is joined with C:Join. A FilerCX
already in SYS:WBStartup is updated instead.
- Installing over a running Filer failed with "object is in use" on every
toolbar and list image: bitmap.image keeps the image files open. Install
now renames the old
images drawer to images.old (a drawer can be
renamed while its files are open), copies the new one, and deletes the
old one when nothing uses it any more (at the end, or by the next
install). It then tells you to restart Filer.
- New Install icon in the OS 4.1 style (a drive with a green arrow), the same
picture as the SFTP and WebDAV handlers' installers. Default tool and tool
types are unchanged (Installer, APPNAME=Filer).
Fixes
Every copy and move wrote past the end of a memory block: the skip flags
were allocated with the size of another structure (20 instead of 32
bytes). This could corrupt memory and crash Filer later.
Copied drawers keep all their protection bits (also "not deletable"),
and their date and comment are set after the contents are copied, since
writing into a drawer changes its date.
"Skip all" in the "drawer already exists" requester skips every later
existing drawer without asking again.
Copying a file onto a drawer of the same name (or a drawer onto a file,
or anything onto a link) was skipped without a word. Filer now says so
and offers Skip / Skip all / Cancel. Nothing is overwritten.
Soft and hard links are copied as links instead of as copies of their
targets (which could also loop through a link to a parent drawer). A soft
link gets a new soft link to the same target (a relative target becomes
a full path). A hard link gets a new hard link on the same volume; to
another volume it is refused with Skip / Skip all / Cancel. Moving a
link on the same volume renames it; across volumes the new link is made
and the old one deleted. Needs dos.library 54.54 (AmigaOS 4.1 FE);
older versions copy the targets as before.
Clone Lister opened the new lister with the defaults from the prefs:
icon view, Show and Sort by settings changed in the lister were lost.
It now passes them along with new command line arguments (VIEW,
ONLYICONS, INFOFILES, SORT, DESCENDING), which can also be used from a
Shell.
Icon view showed an icon without its file or drawer (for example
System:Internet/Edit Connection.info) only as a .info file with a
blank image, or not at all with Info files off. It is now an entry of
its own with its icon, as on Workbench: double-click opens it with
OpenWorkbenchObject() (WbRun can't find it), and Copy, Move, Delete
and Rename act on the .info file. List view is unchanged.
-
OS4Depot mode (spec OD-01..13, Q26-Q30):
- Filer checks that wget is there and supports https before it enters
OS4Depot mode, and says so in a requester when it doesn't.
- Every download runs wget as a process of its own: the "Downloading"
window opens only when it takes longer than a second (also when a
category is opened, which had no window) and has a Cancel button. Cancel
gives wget a second to stop; one that doesn't is left behind, so a
download that never ends no longer blocks the lister.
- A download that fails shows a requester with the file, the host and
the reason from wget's return code; before, nothing happened.
- Downloads go to a name of their own and replace the file in the Work
folder only when complete (the small lists through T:), each lister has
its own search result (in T:), and the wget processes and temporary
files have unique names: several listers or Filers can use OS4Depot mode
at the same time.
- With a Work folder setting other than
OS4Depot:, a double-clicked file
went to the wrong place (the category was the path minus 9 characters).
- The dates of FULLINDEX.readme and FULLINDEXBYDATE.readme were read from
a wrong path (two colons).
- A lister closed in OS4Depot mode deletes its search result in T: and
the copies of cancelled downloads.
Thumber was looked for in the current drawer, which is Filer's own drawer
only when Filer is started from its icon; started from a Shell, a user
button or FilerCX elsewhere, Filer relied on SYS:Utilities or an AppDir:
entry and could report "The Thumber process could not be started". Filer
now looks in its own drawer (PROGDIR:) first, as the Readme says.
Selecting by pattern (and the user button requesters, the search, a
snapshot) saves values Filer remembers in ENV:filer.prefs. Every running
lister then read its drawer again, and an OS4Depot lister downloaded its
file list again. The listers now only refresh when another setting
changed (spec PRF-04).
FilerPrefs: Cancel or the close gadget after Test kept the tested
settings. FilerPrefs now remembers the settings, user buttons and file
types from when it was opened and puts them back (the listers change
back too); Save and Use keep them (spec PRF-02).
Snapshot and Unsnapshot saved all current settings to ENVARC:, so
settings that were only used or tested became permanent. They now change
only the lister's position, size and column widths there (spec PRF-05).
Icon view had its own simple scroll bar. It now uses the system's
scroller (scroller.gadget), so it looks and works like the list view's:
arrows, knob and the GUI settings (FileBrowser 1.2). Everything icon view
draws is clipped to the view and to the inside of the window's borders:
a piece of the scroll bar was once left on the status bar and the window
border after scrolling quickly.
List view showed a picture's thumbnail only right after Thumber had made
it. A thumbnail that already existed was never shown: going back to a
drawer loaded the file type icon first, and the icon loading skips
entries that have an icon; and the first drawer of a new lister is read
before its window opens, when the icon loading isn't started at all. Now
the thumbnail is loaded instead of the file type icon, and the icon
loading starts when the window opens (spec LST-04).
Archives with arcedit (spec ARC-11, ARC-25, ARC-26): Move to from
archive view unpacks the entries and then deletes them from the
archive (one question); an entry that was skipped or failed stays.
Move to an archive lister adds the files and then deletes the
originals that are in the archive now. A drop on an archive lister
follows the normal drop rules (move, Shift copies; with "Emulate
Workbench" a move only on the same volume) instead of always copying.
User buttons (spec UB-07, UB-14): with "Quote filenames" on, {d},
{s}, {Rd}, {Rf} and {Ro} were never quoted, so a drawer with a
space in its name broke the command. They are now quoted together with
what follows them up to the next space (unless the command already has
them inside quotes). The destination question came from "Source as
home" being off, so a {d} button with it on only got an error and
buttons that don't use {d} were asked; now exactly the buttons that
use {d} ask.
Root view (spec RT-05): Rename skipped selected assigns without a
word, and with only assigns selected it did nothing at all. Rename is
now disabled while only assigns are selected.
Every selection change leaked a little memory: the status bar counts
(GetSelectedData()) built a list of the selected entries and never
freed it.
Copy to from an archive skipped stored links without a word. They are
now unpacked as soft links to the stored target; Unix-style targets
(../lib/x) are turned into AmigaDOS paths (/lib/x).
An archive that xadmaster recognises but can't read, or reads with
damaged data, is now reported when it is opened: "The archive ... is
damaged: <reason>. Do you want to continue anyway?". Cancel does nothing;
Continue opens what can be read (or starts the file as before). Before,
only a line was written to the console. Such an archive is also closed
again when it isn't shown (it stayed open: "object is in use" until the
next reboot).
Rename (and Relabel in the volume list) with the name left unchanged
showed the same requester again until Skip or Cancel was pressed; it now
goes on to the next entry.
Paste and drops between listers read their clip file without checking
its first line (the check was always true), cut the last letter of a last
line without a newline, and took an empty line as the current drawer. The
first line must now be COPY/CUT (clipboard) or COPY/MOVE/WORKBENCH (drop),
else the file is ignored; empty lines are skipped. Drops on an archive
lister check the first line too.
Automatic icons: the icon that goes along with a copied, moved or
renamed entry was loaded and saved again through icon.library, so it got
new bytes and the current date. It is now copied as a plain file (same
bytes, date, protection bits and comment), and renamed on a move within
a volume and on Rename.
Copying many files into a drawer shown in a lister was very slow (100
small files: 25 s, C:Copy under 1 s): the lister got a change notice for
every new file and read the whole drawer again each time. It now reads the
drawer once the notices stop for 0.2 s, and at least once a second while
they keep coming (timer.device). Now 2.7 s.
Copying a drawer into itself was only caught when both paths were written
the same way: through an assign or a device name (RAM:T into T:x) it
copied into itself until the disk was full. Filer now compares the
drawers themselves.
Inside a copied drawer, the requester for an entry that is neither a file,
a drawer nor a link had its buttons mixed up (Cancel went on, Skip acted
as Skip all, Skip all cancelled).
Saving in FilerPrefs could remove every user button row from running
Filers. AmigaOS sends the change notice for ENV:filer.userbuttons as
soon as FilerPrefs opens the file to write it, while it is still empty,
and none when the writing is done: Filer read the empty file. Filer now
waits until a changed config file stops growing before reading it (the
size is checked every 1/5 s, at most 2 s), for the user buttons, the file
types and the prefs. (ENV: has no Rename, so FilerPrefs can't replace the
file in one step.) FilerPrefs writes both files through one function
now, which also frees the path buffers it used to leak.
Icon view: dragging a selection box past the top or bottom of the view
(which scrolls it) drew lines of the box outside the lister's pane. The
box is now drawn only inside the view, its corner stays inside the view
while it scrolls, and the mouse wheel scrolls while a box is dragged
(FileBrowser 1.1, openamiga project 52).
Icon view: pieces of the list view (its frame and scroller) stayed
visible in the thin gaps around the cells and the scroll bar after
switching views. Icon view now paints those gaps (FileBrowser 1.1).
Icon view: Parent and the assigns in the root view were drawn as a flat
image in a grey box. They used the system's default drawer icon from
GetDefDiskObject(), which has no screen, so its transparency was lost.
They now get Filer's own big icons (images/list_parent.info,
list_assign.info, list_device.info), as in archive mode and the list;
the system default icons stay as a fallback, loaded for the screen.
A running Filer kept every toolbar and list image file it had loaded open
("object is in use"), and also the picture files of user buttons. The
cause: bitmap.image with BITMAP_SourceFile keeps its picture datatype
object, and a datatype object keeps its file open for as long as it lives
(checked on the guest with a small test program). New ImageFile.c
loads the picture through datatypes into an ARGB bitmap of Filer's own,
disposes the datatype object at once (closing the file) and gives the
bitmap to bitmap.image (BITMAP_BitMap, BITMAP_HasAlpha). The images
look the same (at most 8 of 255 levels of alpha rounding). On a palette
screen, or with a bitmap.image older than 53.6, the old way is used.
datatypes.library is now opened by Filer.
Automatic icons: when a file or drawer and its icon were both selected
(for example after Select Contents), the file took its icon along and then
Filer handled the icon again as its own entry. Delete showed "Error while
deleting '<name>.info': object not found" for every such icon, and copy
showed "The file '<name>.info' already exists in destination folder".
Delete, copy and move (buttons, menus, cut/copy/paste and drag and drop)
and the OS4Depot download delete now skip a selected icon whose file is
selected too. Drawer contents were not affected: inside a drawer every
.info is handled once as a plain file. Moves gave no error (tested on
the same volume and to another volume), because icon.library finds no
icon for a name that already ends in .info.
Copying was very slow with the AsyncIO DOS copy (dos.library 54.91+), present
since 2022: it was given sizeof(buffer) as the buffer length, and buffer
is a pointer, so files were copied 4 bytes at a time. It now uses the real
16 KB buffer. Files up to 64 KB are copied with plain FRead/FWrite,
because the AsyncIO wait loop sleeps at least one tick (20 ms) per file.
Measured on the QEMU guest, RAM: to Work: by drag and drop (the times
include about 3 s for the scripted drag): a 4 MB file took 84 s and now
takes 4 s, and a drawer of 200 3 KB files took 45 s and now takes 9 s.
FilerCX started from Workbench (WBStartup) quit at once and never showed in
Exchange: it looked for its icon by the CLI program name, which a Workbench
start doesn't have. It now reads PROGDIR: + its name from the Workbench
start message (or the CLI), so the tool types are found either way.
Library calls: wrong tag lists and storage sizes (for example
AllocVecTags without TAG_DONE, 16-bit BOOL storage).
Memory leaks and uninitialised values, for example an ExamineData never
freed in the root view, file type entries never freed in FilerCX, user
button defaults when a file has } without {, the notify request pointer.
Notify: requests are freed and cleared after EndNotify. A double
EndNotify crashed dos_filedir_notify, after which every Filer hung on
quit.
-
Archive mode:
- Leaving it (Root, path field, history, OS4Depot, quit) frees the context.
This was the cause of the 53.39 "unknown file type" DSI.
- An archive that can't be opened no longer switches to archive view; the
double-click falls back to WbRun.
- Drawers inside archives are shown as drawers, with their real protection
bits.
- Window title shows
[Archive].
- Find and Check size are disabled in archive view.
- User buttons that need real file names are refused with a requester.
Drag & drop between Filer windows: the dropclip is written under a temporary
name and renamed when complete, so drops arrive again (move, Shift copy,
drawers, several files).
Listings no longer open every file to check whether it's an archive (up to
64 KB read per file on each scan, because xadmaster's Windows self-extractor
clients need that much). The check is done on double-click instead:
xadmaster opens just that file; "not an archive" falls through to WbRun
silently, real errors are still reported.
File lists: O(1) appends, merge sort and hashed lookups. Same order as
before, much faster on big folders.
FilerCX: starting it a second time toggles it off cleanly instead of
crashing on a failed broker.
FilerPrefs: the thumbnail "ignore devices" field.
Icon and thumbnail "ignore devices" lists compare whole device names
(case-insensitive, separated by spaces or commas, colon optional). Before,
any device whose letters appeared in order in a list entry was ignored too
(with "FTP:", also F:, TP: and FP:).
The default for both "Devices to ignore" lists (icons and thumbnails) is
now FTP: SFTP: (was FTP:), so the SFTP: handler is not asked for icons
or thumbnails either. A list set in the prefs stays as it is.
No reading of the window's mouse position while the window is iconified.
OS4depot.c renamed to OS4Depot.c to match the Makefile.
Memory leak: a lister that quit kept its list (about 2.9 KB per entry,
14 MB for a drawer of 5000 files) allocated after every run; only the list
header was freed. The rows and their data are freed now (spec ALL-09).
Crash when the prefs changed (FilerPrefs Save or Use) while a lister
showed real icons: the default icon images were freed while the list still
used them, and the next redraw drew freed images. The list is detached
first now, and read again with the new icons.
The status bar showed the selected size as the total size of the drawer
after any click ("1000 files, 0 folders, 0 B"). The total is all files
again (spec LST-05).
Root view (spec RT-06): the Pattern button is greyed out, like the other
buttons that don't apply to volumes and assigns.
Moving a soft link with a relative target to another drawer on the same
volume renamed it, so it pointed at the wrong place. It is now made anew
with the full path, as a copy does (spec COPY-17).
Copy to out of an archive: when unpacked links point at nothing (their
targets weren't unpacked), one requester says how many (spec ARC-09).
New and changed behaviour
- New toolbar button Unpack (spec ARC-29 to ARC-31; add it to the toolbar in
FilerPrefs): unpacks the selected archives through xadmaster straight into
the destination lister's drawer, as Copy to from archive view does. Other
selected entries are left alone; unpacked archives are deselected.
- Root view (spec RT-07): it follows the DOS list by itself. A volume
mounted or removed (USB stick, CD), a relabel, or an assign made or
removed elsewhere shows up within a moment, without Update; the
selection is kept.
- Version 53.50 (15.11.2026) for Filer, FilerCX, FilerPrefs and Thumber.
- Icon view (FileBrowser gadget, OpenAmiga project 52): Lister > Show >
As list / As icons, Only icons / All files and Info files, per lister.
Full-size icons, thumbnails or DefIcons, cells sized by the icon size
setting; FilerPrefs has separate general, list mode and icon mode icon
settings.
- Destination picker: Copy to, Move to and user buttons that need a
destination offer the folders of the other listers when no destination is
set; the requester title names the operation.
- Double-click order:
.info → matching file type's launcher → archive view
→ WbRun.
- New
Filer.xadmaster preference (default on) with a "Browse archives
(xadmaster)" checkbox in FilerPrefs.
- OS4Depot: https default host, Host and Work folder fields in FilerPrefs, and
an OS4Depot menu (Browse, Recent files, Leave OS4Depot).
- Archive mode can change archives when the
arcedit command is installed
(a separate tool, like LhA or wget; Filer works the same without it).
Opening an archive runs arcedit <archive> INFO, which enables what the
archive allows: Delete, Rename (an entry's .info goes along with
automatic icons), Edit comment and Set protection (drawers optionally with
their contents). Files and drawers dropped on the lister, from another
Filer or from Workbench, are added to the drawer shown (always copied,
with their .info files when automatic icons are on). arcedit's own error
message is shown when an operation fails; the archive is then unchanged,
and Filer asks arcedit again what is still allowed. While arcedit runs,
the lister lets go of the archive file (xadmaster keeps it open otherwise);
afterwards the archive is read again, in the same drawer or the nearest one
left. Without arcedit, or for archives it can't change, archive mode stays
read-only as before. Needs arcedit 1.0.1 for protection bits of LHA entries
made on Unix to show.
- Archive mode: Copy to unpacks the selected entries (drawers with all they
hold) into the destination with xadmaster, keeping protection bits, dates
and file notes, relative to the drawer shown; existing files get the usual
Replace / Replace all / Skip / Skip all / Cancel requester, and with
automatic icons an entry's .info goes along. Edit and double-click unpack
the file to RAM: under a unique name (readme.txt -> readme_3f2a91c4.txt,
its .info from the archive under the same name) and then do what they do
for that file: Edit runs the editor, double-click opens the information
window, the file type's launcher, archive view or WbRun. Move to stays off.
- An archive lister can be the destination when arcedit can add to it
("Set Destination" is active then; the destination path names the drawer
shown inside the archive). Copy to from a folder lister sends the files to
it, and it adds them through arcedit, as for a drop. Move to an archive,
or copying from one archive into another, explains that files can only be
copied into an archive from a folder.
- Every action that changes an archive (delete, rename, comment, protect,
adding files by Copy to or drag & drop) first asks "This will modify the
file <archive> do you wish to proceed?" (OK/Cancel), once per action
however many entries it covers; Cancel stops the whole action. In an
archive it is Delete's only question.
- Icon view: the drag selection box follows the pointer everywhere in the
view, also in the empty space below the last row (it stopped at the last
row before).
- New Lister > Sort by menu (below Show): Name, Size, Date, Comment and
Reverse order. It sets the same per-lister order as the column titles, in
list and icon view; the checkmarks follow title clicks and the titles
follow the menu. A new lister starts with "Default sort order" from the
prefs. The root view sorts by name only. Column titles now also sort in
archive view.
- Clone Lister in archive view opens the new lister in archive view at the
same drawer. Filer started with a path into an archive
("Work:a.lha/docs") opens it that way.
- Archive mode in icon view follows the icon view's Icon size setting: it
always shows the default drawer/file/parent icons the list uses with "Show
real icons" (whether that is set or not), at full size (scaled down only to
the icon size, like folders), not the list's small images. OS4Depot's
icon view does the same (drawer, package, readme, tool and parent icons).
List view is unchanged.
- New
Filer.arcedit.workdir preference: FilerPrefs, General >
Miscellaneous, "Archive editing (arcedit)" > Work folder. When set, Filer
passes it to arcedit (WORKDIR, arcedit 1.1) and arcedit keeps its
temporary files there; empty (the default) passes nothing, so arcedit
uses the archive's own drawer.
Catalogs
- New strings for the OS4Depot menu and settings, the archive requesters and
title, and the xadmaster checkbox, in English and Swedish.
- Strings 3094-3098 for the arcedit requesters (error, warnings, wait), in
English and Swedish.
- Strings 3099-3100 for extracting from archives (error, wait), in English
and Swedish.
- Strings 3101-3102 for the archive change question and the copy-only
notice, in English and Swedish.
- Strings 4060-4065 for the Sort by menu, in English and Swedish.
- String 3107 for the damaged archive question, in English and Swedish.
- Strings 3103-3106 for the copy requesters (drawer or file in the way, hard
link to another volume, link not created), in English and Swedish.
- FilerPrefs strings 9092-9094 for the arcedit work folder, in English and
Swedish.
- Swedish catalogs updated to 53.35: "Okey" → "OK" (also in English),
"Separator" → "Avdelare", "Editor:" → "Redigerare:", a stray trailing space
removed.
Documentation
documentation/list_rendering_plan.md: plan for one generic list renderer
(plan only, no code yet).
documentation/spec.md: behaviour specification (file operations so
far); the test suite is written from it.
README.md (GitHub front page): a copy of this change log, made by
tools/update_readme.sh (also run by make_lha.sh).
Checked, no change needed
- Drag & drop between Filer and Workbench in both directions, move and copy.
- The 53.39 crash with unknown files: reproduced with 53.39, fixed in 53.35.
|